1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133 | /* -*- Mode: C; indent-tabs-mode: nil; c-basic-offset: 4; tab-width: 4 -*-
baul-view-factory.c: register and create BaulViews
Copyright (C) 2004 Red Hat Inc.
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License as
published by the Free Software Foundation; either version 2 of the
License, or (at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
General Public License for more details.
You should have received a copy of the GNU General Public
License along with this program; if not, write to the
Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
Boston, MA 02110-1301, USA.
Author: Alexander Larsson <alexl@redhat.com>
*/
#include "baul-view-factory.h"
static GList *registered_views;
void
baul_view_factory_register (BaulViewInfo *view_info)
{
g_return_if_fail (view_info != NULL);
g_return_if_fail (view_info->id != NULL);
g_return_if_fail (baul_view_factory_lookup (view_info->id) == NULL);
registered_views = g_list_append (registered_views, view_info);
}
const BaulViewInfo *
baul_view_factory_lookup (const char *id)
{
GList *l;<--- Variable 'l' can be declared as pointer to const
BaulViewInfo *view_info = NULL;<--- The scope of the variable 'view_info' can be reduced. [+]The scope of the variable 'view_info' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
g_return_val_if_fail (id != NULL, NULL);
for (l = registered_views; l != NULL; l = l->next)
{
view_info = l->data;
if (strcmp (view_info->id, id) == 0)
{
return view_info;
}
}
return NULL;
}
BaulView *
baul_view_factory_create (const char *id,
BaulWindowSlotInfo *slot)
{
const BaulViewInfo *view_info;
BaulView *view;
view_info = baul_view_factory_lookup (id);
if (view_info == NULL)
{
return NULL;
}
view = view_info->create (slot);
if (g_object_is_floating (view))
{
g_object_ref_sink (view);
}
return view;
}
gboolean
baul_view_factory_view_supports_uri (const char *id,
GFile *location,
GFileType file_type,
const char *mime_type)
{
const BaulViewInfo *view_info;
char *uri;
gboolean res;
view_info = baul_view_factory_lookup (id);
if (view_info == NULL)
{
return FALSE;
}
uri = g_file_get_uri (location);
res = view_info->supports_uri (uri, file_type, mime_type);
g_free (uri);
return res;
}
GList *
baul_view_factory_get_views_for_uri (const char *uri,
GFileType file_type,
const char *mime_type)
{
GList *l, *res;<--- Variable 'l' can be declared as pointer to const
const BaulViewInfo *view_info = NULL;<--- The scope of the variable 'view_info' can be reduced. [+]The scope of the variable 'view_info' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
res = NULL;
for (l = registered_views; l != NULL; l = l->next)
{
view_info = l->data;
if (view_info->supports_uri (uri, file_type, mime_type))
{
if (view_info->single_view)
{
g_list_free_full (res, g_free);
res = g_list_prepend (NULL, g_strdup (view_info->id));
break;
} else {
res = g_list_prepend (res, g_strdup (view_info->id));
}
}
}
return g_list_reverse (res);
}
|