1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161 | /*
* This file is part of libslab.
*
* Copyright (c) 2006 Novell, Inc.
*
* Libslab is free software; you can redistribute it and/or modify it under the
* terms of the GNU Lesser General Public License as published by the Free
* Software Foundation; either version 2 of the License, or (at your option)
* any later version.
*
* Libslab is distributed in the hope that it will be useful, but WITHOUT ANY
* WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
* FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for
* more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with libslab; if not, write to the Free Software Foundation, Inc., 51
* Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
#include "slab-cafe-util.h"
#include "libslab-utils.h"
#include <gio/gio.h>
#include <string.h>
CafeDesktopItem *
load_desktop_item_from_unknown (const gchar *id)
{
CafeDesktopItem *item;
gchar *basename;
GError *error = NULL;
item = cafe_desktop_item_new_from_uri (id, 0, &error);
if (! error)
return item;
else {
g_error_free (error);
error = NULL;
}
item = cafe_desktop_item_new_from_file (id, 0, &error);
if (! error)
return item;
else {
g_error_free (error);
error = NULL;
}
item = cafe_desktop_item_new_from_basename (id, 0, &error);
if (! error)
return item;
else {
g_error_free (error);
error = NULL;
}
basename = g_strrstr (id, "/");
if (basename) {
basename++;
item = cafe_desktop_item_new_from_basename (basename, 0, &error);
if (! error)
return item;
else {
g_error_free (error);
error = NULL;
}
}
return NULL;
}
gboolean
open_desktop_item_exec (CafeDesktopItem * desktop_item)
{
GError *error = NULL;
if (!desktop_item)
return FALSE;
cafe_desktop_item_launch (desktop_item, NULL, CAFE_DESKTOP_ITEM_LAUNCH_ONLY_ONE | CAFE_DESKTOP_ITEM_LAUNCH_DO_NOT_REAP_CHILD, &error);
if (error)
{
g_warning ("error launching %s [%s]\n",
cafe_desktop_item_get_location (desktop_item), error->message);
g_error_free (error);
return FALSE;
}
return TRUE;
}
gboolean
open_desktop_item_help (CafeDesktopItem * desktop_item)
{
const gchar *doc_path;
gchar *help_uri;<--- The scope of the variable 'help_uri' can be reduced. [+]The scope of the variable 'help_uri' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
GError *error;
if (!desktop_item)
return FALSE;
doc_path = cafe_desktop_item_get_string (desktop_item, "DocPath");
if (doc_path)
{
help_uri = g_strdup_printf ("help:%s", doc_path);
error = NULL;
if (!ctk_show_uri_on_window (NULL, help_uri, ctk_get_current_event_time (), &error))
{
g_warning ("error opening %s [%s]\n", help_uri, error->message);
g_free (help_uri);
g_error_free (error);
return FALSE;
}
g_free (help_uri);
}
else
return FALSE;
return TRUE;
}
void
copy_file (const gchar * src_uri, const gchar * dst_uri)
{
GFile *src;
GFile *dst;
GError *error = NULL;
gboolean res;
src = g_file_new_for_uri (src_uri);
dst = g_file_new_for_uri (dst_uri);
res = g_file_copy (src, dst,
G_FILE_COPY_NONE,
NULL, NULL, NULL, &error);
if (!res)
{
g_warning ("error copying [%s] to [%s]: %s.", src_uri, dst_uri, error->message);
g_error_free (error);
}
g_object_unref (src);
g_object_unref (dst);
}
|