1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133 | /*
* panel-applet-info.c
*
* Copyright (C) 2010 Carlos Garcia Campos <carlosgc@gnome.org>
* Copyright (C) 2010 Vincent Untz <vuntz@gnome.org>
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
* 02110-1301, USA.
*/
#include <config.h>
#include "panel-applet-info.h"
struct _CafePanelAppletInfo {
gchar *iid;
gchar *name;
gchar *comment;
gchar *icon;
gchar **old_ids;
gboolean x11_supported;
gboolean wayland_supported;
};
CafePanelAppletInfo *
cafe_panel_applet_info_new (const gchar *iid,
const gchar *name,
const gchar *comment,
const gchar *icon,
const gchar **old_ids,
gboolean x11_supported,
gboolean wayland_supported)
{
CafePanelAppletInfo *info;
info = g_slice_new0 (CafePanelAppletInfo);
info->iid = g_strdup (iid);
info->name = g_strdup (name);
info->comment = g_strdup (comment);
info->icon = g_strdup (icon);
/* CafeComponent compatibility */
if (old_ids != NULL) {
int i, len;<--- The scope of the variable 'i' can be reduced. [+]The scope of the variable 'i' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
len = g_strv_length ((gchar **) old_ids);
if (len > 0) {
info->old_ids = g_new0 (gchar *, len + 1);
for (i = 0; i < len; i++)
info->old_ids[i] = g_strdup (old_ids[i]);
}
}
info->x11_supported = x11_supported;
info->wayland_supported = wayland_supported;
if (!x11_supported && !wayland_supported)
g_warning ("Applet %s has no supported platforms", name);
return info;
}
void
cafe_panel_applet_info_free (CafePanelAppletInfo *info)
{
if (!info)
return;
g_free (info->iid);
g_free (info->name);
g_free (info->comment);
g_free (info->icon);
g_strfreev (info->old_ids);
g_slice_free (CafePanelAppletInfo, info);
}
const gchar *
cafe_panel_applet_info_get_iid (CafePanelAppletInfo *info)<--- Parameter 'info' can be declared as pointer to const
{
return info->iid;
}
const gchar *
cafe_panel_applet_info_get_name (CafePanelAppletInfo *info)<--- Parameter 'info' can be declared as pointer to const
{
return info->name;
}
const gchar *
cafe_panel_applet_info_get_description (CafePanelAppletInfo *info)<--- Parameter 'info' can be declared as pointer to const
{
return info->comment;
}
const gchar *
cafe_panel_applet_info_get_icon (CafePanelAppletInfo *info)<--- Parameter 'info' can be declared as pointer to const
{
return info->icon;
}
const gchar * const *
cafe_panel_applet_info_get_old_ids (CafePanelAppletInfo *info)
{
return (const gchar * const *) info->old_ids;
}
gboolean
cafe_panel_applet_info_get_x11_supported (CafePanelAppletInfo *info)<--- Parameter 'info' can be declared as pointer to const
{
return info->x11_supported;
}
gboolean
cafe_panel_applet_info_get_wayland_supported (CafePanelAppletInfo *info)<--- Parameter 'info' can be declared as pointer to const
{
return info->wayland_supported;
}
|