1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413 | /*
* panel-layout.c: methods to load default panels from file
*
* Copyright (C) 2011 Novell, Inc.
* 2012 Stefano Karapetsas
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
* 02110-1301, USA.
*
* Authors:
* Stefano Karapetsas <stefano@karapetsas.com>
*/
#include <config.h>
#include <string.h>
#include <glib.h>
#include <gio/gio.h>
#ifdef HAVE_X11
#include <cdk/cdkx.h>
#endif
#include <libcafe-desktop/cafe-dconf.h>
#include <libcafe-desktop/cafe-gsettings.h>
#include "panel-layout.h"
#include "panel-profile.h"
#include "panel-schemas.h"
#include "panel-enums.h"
#define PANEL_LAYOUTS_DIR PANELDATADIR "/layouts/"
typedef struct {
const char *name;
GType type;
} PanelLayoutKeyDefinition;
static PanelLayoutKeyDefinition panel_layout_toplevel_keys[] = {
{ PANEL_TOPLEVEL_NAME_KEY, G_TYPE_STRING },
{ PANEL_TOPLEVEL_SCREEN_KEY, G_TYPE_INT },
{ PANEL_TOPLEVEL_MONITOR_KEY, G_TYPE_INT },
{ PANEL_TOPLEVEL_EXPAND_KEY, G_TYPE_BOOLEAN },
{ PANEL_TOPLEVEL_ORIENTATION_KEY, G_TYPE_STRING },
{ PANEL_TOPLEVEL_SIZE_KEY, G_TYPE_INT },
{ PANEL_TOPLEVEL_X_KEY, G_TYPE_INT },
{ PANEL_TOPLEVEL_Y_KEY, G_TYPE_INT },
{ PANEL_TOPLEVEL_X_RIGHT_KEY, G_TYPE_INT },
{ PANEL_TOPLEVEL_Y_BOTTOM_KEY, G_TYPE_INT },
{ PANEL_TOPLEVEL_X_CENTERED_KEY, G_TYPE_BOOLEAN },
{ PANEL_TOPLEVEL_Y_CENTERED_KEY, G_TYPE_BOOLEAN },
{ PANEL_TOPLEVEL_AUTO_HIDE_KEY, G_TYPE_BOOLEAN },
{ PANEL_TOPLEVEL_ENABLE_ANIMATIONS_KEY, G_TYPE_BOOLEAN },
{ PANEL_TOPLEVEL_ENABLE_BUTTONS_KEY, G_TYPE_BOOLEAN },
{ PANEL_TOPLEVEL_ENABLE_ARROWS_KEY, G_TYPE_BOOLEAN },
{ PANEL_TOPLEVEL_HIDE_DELAY_KEY, G_TYPE_INT },
{ PANEL_TOPLEVEL_UNHIDE_DELAY_KEY, G_TYPE_INT },
{ PANEL_TOPLEVEL_AUTO_HIDE_SIZE_KEY, G_TYPE_INT },
{ PANEL_TOPLEVEL_ANIMATION_SPEED_KEY, G_TYPE_STRING }
};
static PanelLayoutKeyDefinition panel_layout_object_keys[] = {
{ PANEL_OBJECT_TYPE_KEY, G_TYPE_STRING },
{ PANEL_OBJECT_TOPLEVEL_ID_KEY, G_TYPE_STRING },
{ PANEL_OBJECT_POSITION_KEY, G_TYPE_INT },
{ PANEL_OBJECT_PANEL_RIGHT_STICK_KEY, G_TYPE_BOOLEAN },
{ PANEL_OBJECT_LOCKED_KEY, G_TYPE_BOOLEAN },
{ PANEL_OBJECT_APPLET_IID_KEY, G_TYPE_STRING },
{ PANEL_OBJECT_ATTACHED_TOPLEVEL_ID_KEY, G_TYPE_STRING },
{ PANEL_OBJECT_TOOLTIP_KEY, G_TYPE_STRING },
{ PANEL_OBJECT_USE_CUSTOM_ICON_KEY, G_TYPE_BOOLEAN },
{ PANEL_OBJECT_CUSTOM_ICON_KEY, G_TYPE_STRING },
{ PANEL_OBJECT_USE_MENU_PATH_KEY, G_TYPE_BOOLEAN },
{ PANEL_OBJECT_MENU_PATH_KEY, G_TYPE_STRING },
{ PANEL_OBJECT_HAS_ARROW_KEY, G_TYPE_BOOLEAN },
{ PANEL_OBJECT_LAUNCHER_LOCATION_KEY, G_TYPE_STRING },
{ PANEL_OBJECT_ACTION_TYPE_KEY, G_TYPE_STRING }
};
/*
* return the default layout file path, making it overridable by
* distributions
*/
static gchar *
panel_layout_filename ()
{
GSettings *settings;
gchar *layout;
gchar *filename;
settings = g_settings_new (PANEL_SCHEMA);
layout = g_settings_get_string (settings, PANEL_DEFAULT_LAYOUT);
if (g_str_has_prefix (layout, "/")) {
filename = g_strdup (layout);
}
else {
filename = g_strdup_printf (PANEL_LAYOUTS_DIR "%s.layout", layout);
}
g_free (layout);
g_object_unref (settings);
if (g_file_test (filename, G_FILE_TEST_IS_REGULAR)) {
return filename;
}
else {
g_free (filename);
return NULL;
}
}
static gboolean
panel_layout_append_group_helper (GKeyFile *keyfile,
const char *group,
int set_screen_to,
const char *group_prefix,
char *id_list_key,
const char *schema,
const char *path_prefix,
const char *default_prefix,
PanelLayoutKeyDefinition *key_definitions,
int key_definitions_len,
const char *type_for_error_message)
{
gboolean retval = FALSE;
const char *id;
char *unique_id = NULL;
char *path = NULL;
GSettings *settings = NULL;
char **keyfile_keys = NULL;
char *value_str;<--- The scope of the variable 'value_str' can be reduced. [+]The scope of the variable 'value_str' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
int value_int;<--- The scope of the variable 'value_int' can be reduced. [+]The scope of the variable 'value_int' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
gboolean value_boolean;
int i, j;<--- The scope of the variable 'j' can be reduced. [+]The scope of the variable 'j' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
GError *error = NULL;
gchar **existing_ids;
gboolean existing_id = FALSE;
gchar *dir = NULL;
gchar *dconf_path = NULL;
PanelGSettingsKeyType type;
/* Try to extract an id from the group, by stripping the prefix,
* and create a unique id out of that */
id = group + strlen (group_prefix);
while (g_ascii_isspace (*id))
id++;
if (!*id)
id = NULL;
if (id && !cafe_gsettings_is_valid_keyname (id, &error)) {
g_warning ("Invalid id name in layout '%s' (%s)", id, error->message);
g_error_free (error);
return FALSE;
}
if (g_strcmp0 (id_list_key, PANEL_TOPLEVEL_ID_LIST_KEY) == 0) {
dir = "toplevels";
type = PANEL_GSETTINGS_TOPLEVELS;
}
else if (g_strcmp0 (id_list_key, PANEL_OBJECT_ID_LIST_KEY) == 0) {
dir = "objects";
type = PANEL_GSETTINGS_OBJECTS;
}
else {
g_critical ("Unknown key \"%s\"", id_list_key);
return FALSE;
}
dconf_path = g_strdup_printf (PANEL_RESOURCE_PATH "/%s", dir);
existing_ids = cafe_dconf_list_subdirs (dconf_path, TRUE);
if (id) {
if (set_screen_to > 0) {
id = g_strdup_printf ("%s-screen%d", id, set_screen_to);
}
for (i = 0; existing_ids[i]; i++) {
if (!strcmp (existing_ids[i], id)) {
existing_id = TRUE;
}
}
}
g_strfreev (existing_ids);
g_free (dconf_path);
if (existing_id || !id)
unique_id = panel_profile_find_new_id (type);
else
unique_id = g_strdup (id);
path = g_strdup_printf ("%s%s/", path_prefix, unique_id);
settings = g_settings_new_with_path (schema, path);
g_free (path);
keyfile_keys = g_key_file_get_keys (keyfile, group, NULL, NULL);
if (keyfile_keys) {
/* validate/add keys from the keyfile */
for (i = 0; keyfile_keys[i] != NULL; i++) {
gboolean found = FALSE;
for (j = 0; j < key_definitions_len; j++) {
if (g_strcmp0 (keyfile_keys[i],
key_definitions[j].name) == 0) {
found = TRUE;
break;
}
}
if (!found) {
g_warning ("Unknown key '%s' for %s",
keyfile_keys[i],
unique_id);
return FALSE;
}
switch (key_definitions[j].type) {
case G_TYPE_STRING:
value_str = g_key_file_get_string (keyfile,
group, keyfile_keys[i],
NULL);
if (value_str)
g_settings_set_string (settings,
key_definitions[j].name,
value_str);
g_free (value_str);
break;
case G_TYPE_INT:
value_int = g_key_file_get_integer (keyfile,
group, keyfile_keys[i],
NULL);
g_settings_set_int (settings,
key_definitions[j].name,
value_int);
break;
case G_TYPE_BOOLEAN:
value_boolean = g_key_file_get_boolean (keyfile,
group, keyfile_keys[i],
NULL);
g_settings_set_boolean (settings,
key_definitions[j].name,
value_boolean);
break;
default:
g_assert_not_reached ();
break;
}
}
if (set_screen_to != -1 &&
g_strcmp0 (schema, PANEL_TOPLEVEL_SCHEMA) == 0)
g_settings_set_int (settings,
PANEL_TOPLEVEL_SCREEN_KEY,
set_screen_to);
GSettings *panel_settings;
panel_settings = g_settings_new (PANEL_SCHEMA);
cafe_gsettings_append_strv (panel_settings,
id_list_key,
unique_id);
g_object_unref (panel_settings);
retval = TRUE;
}
if (keyfile_keys)
g_strfreev (keyfile_keys);
if (settings)
g_object_unref (settings);
if (unique_id)
g_free (unique_id);
return retval;
}
static void
panel_layout_apply_minimal_default (int set_screen_to,
const char *schema,
const char *path_prefix)
{
const char *unique_id = "bottom";
char *path = NULL;
GSettings *settings = NULL;
path = g_strdup_printf ("%s%s/", path_prefix, unique_id);
settings = g_settings_new_with_path (schema, path);
g_return_if_fail(settings);
g_free (path);
g_settings_set_boolean(settings, "expand", TRUE);
g_settings_set_string(settings, "orientation", "bottom");
g_settings_set_int(settings, "size", 24);
g_settings_set_int(settings, "screen", 0);
GSettings *panel_settings;
panel_settings = g_settings_new (PANEL_SCHEMA);
g_return_if_fail(panel_settings);
cafe_gsettings_append_strv (panel_settings,
PANEL_TOPLEVEL_ID_LIST_KEY,
unique_id);
g_object_unref (panel_settings);
g_object_unref (settings);
}
void
panel_layout_apply_default_from_gkeyfile (CdkScreen *screen)
{
int screen_n;
gchar *layout_file = NULL;
GKeyFile *keyfile = NULL;
gchar **groups = NULL;
GError *error = NULL;
int i;
screen_n = 0;
#ifdef HAVE_X11
if (CDK_IS_X11_SCREEN (screen))
screen_n = cdk_x11_screen_get_screen_number (screen);
#endif // HAVE_11
layout_file = panel_layout_filename();
if (layout_file)
{
keyfile = g_key_file_new ();
if (g_key_file_load_from_file (keyfile,
layout_file,
G_KEY_FILE_NONE,
&error))
{
groups = g_key_file_get_groups (keyfile, NULL);
for (i = 0; groups[i] != NULL; i++) {
if (g_strcmp0 (groups[i], "Toplevel") == 0 ||
g_str_has_prefix (groups[i], "Toplevel "))
panel_layout_append_group_helper (
keyfile, groups[i],
screen_n,
"Toplevel",
PANEL_TOPLEVEL_ID_LIST_KEY,
PANEL_TOPLEVEL_SCHEMA,
PANEL_TOPLEVEL_PATH,
PANEL_TOPLEVEL_DEFAULT_PREFIX,
panel_layout_toplevel_keys,
G_N_ELEMENTS (panel_layout_toplevel_keys),
"toplevel");
else if (g_strcmp0 (groups[i], "Object") == 0 ||
g_str_has_prefix (groups[i], "Object "))
panel_layout_append_group_helper (
keyfile, groups[i],
-1,
"Object",
PANEL_OBJECT_ID_LIST_KEY,
PANEL_OBJECT_SCHEMA,
PANEL_OBJECT_PATH,
PANEL_OBJECT_DEFAULT_PREFIX,
panel_layout_object_keys,
G_N_ELEMENTS (panel_layout_object_keys),
"object");
else
g_warning ("Unknown group in default layout: '%s'",
groups[i]);
}
}
else
{
g_warning ("Error while parsing default layout from '%s': %s\n",
layout_file, error->message);
g_error_free (error);
}
}
else {
g_warning ("Cant find the layout file!");
panel_layout_apply_minimal_default(screen_n,
PANEL_TOPLEVEL_SCHEMA,
PANEL_TOPLEVEL_PATH);
}
if (groups)
g_strfreev (groups);
if (keyfile)
g_key_file_free (keyfile);
if (layout_file)
g_free (layout_file);
}
|