/*
* Copyright (C) 2005-2009 Alex Murray <murray.alex@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
#ifdef HAVE_CONFIG_H
#include "config.h"
#endif /* HAVE_CONFIG_H */
#include <cafe-panel-applet.h>
#include <string.h>
#include "sensors-applet.h"
static gboolean sensors_applet_fill(CafePanelApplet *applet,
const gchar *iid,
gpointer data) {
SensorsApplet *sensors_applet;<--- The scope of the variable 'sensors_applet' can be reduced. [+]The scope of the variable 'sensors_applet' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
gboolean retval = FALSE;
if (strcmp(iid, "SensorsApplet") == 0) {
sensors_applet = g_new0(SensorsApplet, 1);
sensors_applet->applet = applet;
sensors_applet_init(sensors_applet);
retval = TRUE;
}
return retval;
}
CAFE_PANEL_APPLET_OUT_PROCESS_FACTORY ("SensorsAppletFactory",
PANEL_TYPE_APPLET,
"SensorsApplet",
sensors_applet_fill,
NULL);