1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112 | /* -*- Mode: C; c-basic-offset: 2; -*- */
/* CdkPixbuf library - test loaders
*
* Copyright (C) 2004 Matthias Clasen <mclasen@redhat.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
#include "config.h"
#include <glib/gstdio.h>
#include "cdk-pixbuf/cdk-pixbuf.h"
#include "test-common.h"
static void
load_image (gpointer data,
gpointer user_data)
{
gchar *filename = data;
const gchar *path;
FILE *file;
int nbytes;<--- The scope of the variable 'nbytes' can be reduced. [+]The scope of the variable 'nbytes' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
guchar buffer[1024];
CdkPixbufLoader *loader;
GError *error = NULL;
loader = cdk_pixbuf_loader_new ();
path = g_test_get_filename (G_TEST_DIST, "test-images/randomly-modified", filename, NULL);
g_test_message ("reading %s", path);
file = g_fopen (path, "rb");
g_assert (file != NULL);
while (!feof (file))
{
nbytes = fread (buffer, 1, sizeof (buffer), file);
cdk_pixbuf_loader_write (loader, buffer, nbytes, &error);
g_assert_no_error (error);
g_thread_yield ();
}
fclose (file);
cdk_pixbuf_loader_close (loader, &error);
if (g_error_matches (error, CDK_PIXBUF_ERROR, CDK_PIXBUF_ERROR_UNKNOWN_TYPE))
{
g_test_message ("Unsupported format");
g_clear_error (&error);
}
g_assert_no_error (error);
g_object_unref (loader);
}
static void
test_threads (void)
{
GThreadPool *pool;
gint iterations;
gint i;
pool = g_thread_pool_new (load_image, NULL, 20, FALSE, NULL);
if (g_test_thorough ())
iterations = 100;
else
iterations = 1;
for (i = 0; i < iterations; i++)
{
if (format_supported ("jpeg"))
g_thread_pool_push (pool, "valid.1.jpeg", NULL);
if (format_supported ("png"))
g_thread_pool_push (pool, "valid.1.png", NULL);
if (format_supported ("gif"))
g_thread_pool_push (pool, "valid.1.gif", NULL);
if (format_supported ("bmp"))
g_thread_pool_push (pool, "valid.1.bmp", NULL);
if (format_supported ("jpeg"))
g_thread_pool_push (pool, "valid.2.jpeg", NULL);
if (format_supported ("xpm"))
g_thread_pool_push (pool, "valid.1.xpm", NULL);
if (format_supported ("tga"))
g_thread_pool_push (pool, "valid.1.tga", NULL);
if (format_supported ("tiff"))
g_thread_pool_push (pool, "valid.1.tiff", NULL);
}
g_thread_pool_free (pool, FALSE, TRUE);
}
int
main (int argc, char **argv)
{
g_test_init (&argc, &argv, NULL);
g_test_add_func ("/pixbuf/threads", test_threads);
return g_test_run ();
}
|