1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160 | /*
* Copyright © 2012 Red Hat Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
*
* Authors: Benjamin Otte <otte@gnome.org>
*/
#include "config.h"
#include "ctkcsstransitionprivate.h"
#include "ctkcsseasevalueprivate.h"
#include "ctkprogresstrackerprivate.h"
G_DEFINE_TYPE (CtkCssTransition, _ctk_css_transition, CTK_TYPE_STYLE_ANIMATION)
static CtkStyleAnimation *
ctk_css_transition_advance (CtkStyleAnimation *style_animation,
gint64 timestamp)
{
CtkCssTransition *source = CTK_CSS_TRANSITION (style_animation);
CtkCssTransition *transition;
transition = g_object_new (CTK_TYPE_CSS_TRANSITION, NULL);
transition->property = source->property;
transition->start = _ctk_css_value_ref (source->start);
transition->ease = _ctk_css_value_ref (source->ease);
ctk_progress_tracker_init_copy (&source->tracker, &transition->tracker);
ctk_progress_tracker_advance_frame (&transition->tracker, timestamp);
return CTK_STYLE_ANIMATION (transition);
}
static void
ctk_css_transition_apply_values (CtkStyleAnimation *style_animation,
CtkCssAnimatedStyle *style)
{
CtkCssTransition *transition = CTK_CSS_TRANSITION (style_animation);
CtkCssValue *value, *end;
double progress;<--- The scope of the variable 'progress' can be reduced. [+]The scope of the variable 'progress' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
CtkProgressState state;
end = ctk_css_animated_style_get_intrinsic_value (style, transition->property);
state = ctk_progress_tracker_get_state (&transition->tracker);
if (state == CTK_PROGRESS_STATE_BEFORE)
value = _ctk_css_value_ref (transition->start);
else if (state == CTK_PROGRESS_STATE_DURING)
{
progress = ctk_progress_tracker_get_progress (&transition->tracker, FALSE);
progress = _ctk_css_ease_value_transform (transition->ease, progress);
value = _ctk_css_value_transition (transition->start,
end,
transition->property,
progress);
}
else
return;
if (value == NULL)
value = _ctk_css_value_ref (end);
ctk_css_animated_style_set_animated_value (style, transition->property, value);
_ctk_css_value_unref (value);
}
static gboolean
ctk_css_transition_is_finished (CtkStyleAnimation *animation)
{
CtkCssTransition *transition = CTK_CSS_TRANSITION (animation);
return ctk_progress_tracker_get_state (&transition->tracker) == CTK_PROGRESS_STATE_AFTER;
}
static gboolean
ctk_css_transition_is_static (CtkStyleAnimation *animation)
{
CtkCssTransition *transition = CTK_CSS_TRANSITION (animation);
return ctk_progress_tracker_get_state (&transition->tracker) == CTK_PROGRESS_STATE_AFTER;
}
static void
ctk_css_transition_finalize (GObject *object)
{
CtkCssTransition *transition = CTK_CSS_TRANSITION (object);
_ctk_css_value_unref (transition->start);
_ctk_css_value_unref (transition->ease);
G_OBJECT_CLASS (_ctk_css_transition_parent_class)->finalize (object);
}
static void
_ctk_css_transition_class_init (CtkCssTransitionClass *klass)
{
GObjectClass *object_class = G_OBJECT_CLASS (klass);
CtkStyleAnimationClass *animation_class = CTK_STYLE_ANIMATION_CLASS (klass);
object_class->finalize = ctk_css_transition_finalize;
animation_class->advance = ctk_css_transition_advance;
animation_class->apply_values = ctk_css_transition_apply_values;
animation_class->is_finished = ctk_css_transition_is_finished;
animation_class->is_static = ctk_css_transition_is_static;
}
static void
_ctk_css_transition_init (CtkCssTransition *transition G_GNUC_UNUSED)
{
}
CtkStyleAnimation *
_ctk_css_transition_new (guint property,
CtkCssValue *start,
CtkCssValue *ease,
gint64 timestamp,
gint64 duration_us,
gint64 delay_us)
{
CtkCssTransition *transition;
g_return_val_if_fail (start != NULL, NULL);
g_return_val_if_fail (ease != NULL, NULL);
transition = g_object_new (CTK_TYPE_CSS_TRANSITION, NULL);
transition->property = property;
transition->start = _ctk_css_value_ref (start);
transition->ease = _ctk_css_value_ref (ease);
ctk_progress_tracker_start (&transition->tracker, duration_us, delay_us, 1.0);
ctk_progress_tracker_advance_frame (&transition->tracker, timestamp);
return CTK_STYLE_ANIMATION (transition);
}
guint
_ctk_css_transition_get_property (CtkCssTransition *transition)
{
g_return_val_if_fail (CTK_IS_CSS_TRANSITION (transition), 0);
return transition->property;
}
|