Cppcheck report - lapiz (cppcheck 2.14.0-1+b1): lapiz/lapiz-message.c

#include "lapiz-message.h"
#include "lapiz-message-type.h"

#include <string.h>
#include <gobject/gvaluecollector.h>

/**
 * SECTION:lapiz-message
 * @short_description: message bus message object
 * @include: lapiz/lapiz-message.h
 *
 * Communication on a #LapizMessageBus is done through messages. Messages are
 * sent over the bus and received by connecting callbacks on the message bus.
 * A #LapizMessage is an instantiation of a #LapizMessageType, containing
 * values for the arguments as specified in the message type.
 *
 * A message can be seen as a method call, or signal emission depending on
 * who is the sender and who is the receiver. There is no explicit distinction
 * between methods and signals.
 */

enum {
	PROP_0,

	PROP_OBJECT_PATH,
	PROP_METHOD,
	PROP_TYPE
};

struct _LapizMessagePrivate
{
	LapizMessageType *type;
	gboolean valid;

	GHashTable *values;
};

G_DEFINE_TYPE_WITH_PRIVATE (LapizMessage, lapiz_message, G_TYPE_OBJECT)<--- There is an unknown macro here somewhere. Configuration is required. If G_DEFINE_TYPE_WITH_PRIVATE is a macro then please configure it.

static void
lapiz_message_finalize (GObject *object)
{
	LapizMessage *message = LAPIZ_MESSAGE (object);

	lapiz_message_type_unref (message->priv->type);
	g_hash_table_destroy (message->priv->values);

	G_OBJECT_CLASS (lapiz_message_parent_class)->finalize (object);
}

static void
lapiz_message_get_property (GObject    *object,
			    guint       prop_id,
			    GValue     *value,
			    GParamSpec *pspec)
{
	LapizMessage *msg = LAPIZ_MESSAGE (object);

	switch (prop_id)
	{
		case PROP_OBJECT_PATH:
			g_value_set_string (value, lapiz_message_type_get_object_path (msg->priv->type));
			break;
		case PROP_METHOD:
			g_value_set_string (value, lapiz_message_type_get_method (msg->priv->type));
			break;
		case PROP_TYPE:
			g_value_set_boxed (value, msg->priv->type);
			break;
		default:
			G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
			break;
	}
}

static void
lapiz_message_set_property (GObject      *object,
			    guint         prop_id,
			    const GValue *value,
			    GParamSpec   *pspec)
{
	LapizMessage *msg = LAPIZ_MESSAGE (object);

	switch (prop_id)
	{
		case PROP_TYPE:
			msg->priv->type = LAPIZ_MESSAGE_TYPE (g_value_dup_boxed (value));
			break;
		default:
			G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
			break;
	}
}

static GValue *
add_value (LapizMessage *message,
	   const gchar  *key)
{
	GValue *value;
	GType type = lapiz_message_type_lookup (message->priv->type, key);

	if (type == G_TYPE_INVALID)
		return NULL;

	value = g_new0 (GValue, 1);
	g_value_init (value, type);
	g_value_reset (value);

	g_hash_table_insert (message->priv->values, g_strdup (key), value);

	return value;
}

static void
lapiz_message_class_init (LapizMessageClass *klass)
{
	GObjectClass *object_class = G_OBJECT_CLASS(klass);

	object_class->finalize = lapiz_message_finalize;
	object_class->get_property = lapiz_message_get_property;
	object_class->set_property = lapiz_message_set_property;

	/**
	 * LapizMessage:object_path:
	 *
	 * The messages object path (e.g. /lapiz/object/path).
	 *
	 */
	g_object_class_install_property (object_class, PROP_OBJECT_PATH,
					 g_param_spec_string ("object-path",
							      "OBJECT_PATH",
							      "The message object path",
							      NULL,
							      G_PARAM_READABLE |
							      G_PARAM_STATIC_STRINGS));

	/**
	 * LapizMessage:method:
	 *
	 * The messages method.
	 *
	 */
	g_object_class_install_property (object_class, PROP_METHOD,
					 g_param_spec_string ("method",
							      "METHOD",
							      "The message method",
							      NULL,
							      G_PARAM_READABLE |
							      G_PARAM_STATIC_STRINGS));

	/**
	 * LapizMEssage:type:
	 *
	 * The message type.
	 *
	 */
	g_object_class_install_property (object_class, PROP_TYPE,
					 g_param_spec_boxed ("type",
					 		     "TYPE",
					 		     "The message type",
					 		     LAPIZ_TYPE_MESSAGE_TYPE,
					 		     G_PARAM_READWRITE |
					 		     G_PARAM_CONSTRUCT_ONLY |
					 		     G_PARAM_STATIC_STRINGS));
}

static void
destroy_value (GValue *value)
{
	g_value_unset (value);
	g_free (value);
}

static void
lapiz_message_init (LapizMessage *self)
{
	self->priv = lapiz_message_get_instance_private (self);

	self->priv->values = g_hash_table_new_full (g_str_hash,
						    g_str_equal,
						    (GDestroyNotify)g_free,
						    (GDestroyNotify)destroy_value);
}

static gboolean
set_value_real (GValue 	     *to,
		const GValue *from)
{
	GType from_type;
	GType to_type;

	from_type = G_VALUE_TYPE (from);
	to_type = G_VALUE_TYPE (to);

	if (!g_type_is_a (from_type, to_type))
	{
		if (!g_value_transform (from, to))
		{
			g_warning ("%s: Unable to make conversion from %s to %s",
				   G_STRLOC,
				   g_type_name (from_type),
				   g_type_name (to_type));
			return FALSE;
		}

		return TRUE;
	}

	g_value_copy (from, to);
	return TRUE;
}

inline static GValue *
value_lookup (LapizMessage *message,
	      const gchar  *key,
	      gboolean	    create)
{
	GValue *ret = (GValue *)g_hash_table_lookup (message->priv->values, key);

	if (!ret && create)
		ret = add_value (message, key);

	return ret;
}

/**
 * lapiz_message_get_method:
 * @message: the #LapizMessage
 *
 * Get the message method.
 *
 * Return value: the message method
 *
 */
const gchar *
lapiz_message_get_method (LapizMessage *message)
{
	g_return_val_if_fail (LAPIZ_IS_MESSAGE (message), NULL);

	return lapiz_message_type_get_method (message->priv->type);
}

/**
 * lapiz_message_get_object_path:
 * @message: the #LapizMessage
 *
 * Get the message object path.
 *
 * Return value: the message object path
 *
 */
const gchar *
lapiz_message_get_object_path (LapizMessage *message)
{
	g_return_val_if_fail (LAPIZ_IS_MESSAGE (message), NULL);

	return lapiz_message_type_get_object_path (message->priv->type);
}

/**
 * lapiz_message_set:
 * @message: the #LapizMessage
 * @...: a %NULL terminated variable list of key/value pairs
 *
 * Set values of message arguments. The supplied @var_args should contain
 * pairs of keys and argument values.
 *
 */
void
lapiz_message_set (LapizMessage *message,
		   ...)
{
	va_list ap;

	g_return_if_fail (LAPIZ_IS_MESSAGE (message));

	va_start (ap, message);
	lapiz_message_set_valist (message, ap);
	va_end (ap);
}

/**
 * lapiz_message_set_valist:
 * @message: the #LapizMessage
 * @var_args: a %NULL terminated variable list of key/value pairs
 *
 * Set values of message arguments. The supplied @var_args should contain
 * pairs of keys and argument values.
 *
 */
void
lapiz_message_set_valist (LapizMessage *message,
			  va_list	var_args)
{
	const gchar *key;

	g_return_if_fail (LAPIZ_IS_MESSAGE (message));

	while ((key = va_arg (var_args, const gchar *)) != NULL)
	{
		/* lookup the key */
		GValue *container = value_lookup (message, key, TRUE);
		GValue value = {0,};
		gchar *error = NULL;

		if (!container)
		{
			g_warning ("%s: Cannot set value for %s, does not exist",
				   G_STRLOC,
				   key);

			/* skip value */
			va_arg (var_args, gpointer);
			continue;
		}

		g_value_init (&value, G_VALUE_TYPE (container));
		G_VALUE_COLLECT (&value, var_args, 0, &error);

		if (error)
		{
			g_warning ("%s: %s", G_STRLOC, error);
			continue;
		}

		set_value_real (container, &value);
		g_value_unset (&value);
	}
}

/**
 * lapiz_message_set_value:
 * @message: the #LapizMessage
 * @key: the argument key
 * @value: (out): the argument value
 *
 * Set value of message argument @key to @value.
 *
 */
void
lapiz_message_set_value (LapizMessage *message,
			 const gchar  *key,
			 GValue	      *value)
{
	GValue *container;
	g_return_if_fail (LAPIZ_IS_MESSAGE (message));

	container = value_lookup (message, key, TRUE);

	if (!container)
	{
		g_warning ("%s: Cannot set value for %s, does not exist",
			   G_STRLOC,
			   key);
		return;
	}

	set_value_real (container, value);
}

/**
 * lapiz_message_set_valuesv:
 * @message: the #LapizMessage
 * @keys: (array length=n_values): keys to set values for
 * @values: (array length=n_values): values to set
 * @n_values: number of arguments to set values for
 *
 * Set message argument values.
 *
 */
void
lapiz_message_set_valuesv (LapizMessage	 *message,
			   const gchar	**keys,
			   GValue        *values,
			   gint		  n_values)
{
	gint i;

	g_return_if_fail (LAPIZ_IS_MESSAGE (message));

	for (i = 0; i < n_values; i++)
	{
		lapiz_message_set_value (message, keys[i], &values[i]);
	}
}

/* FIXME this is an issue for introspection */
/**
 * lapiz_message_get:
 * @message: the #LapizMessage
 * @...: a %NULL variable argument list of key/value container pairs
 *
 * Get values of message arguments. The supplied @var_args should contain
 * pairs of keys and pointers to variables which are set to the argument
 * value for the specified key.
 *
 */
void
lapiz_message_get (LapizMessage	*message,
		   ...)
{
	va_list ap;

	g_return_if_fail (LAPIZ_IS_MESSAGE (message));

	va_start (ap, message);
	lapiz_message_get_valist (message, ap);
	va_end (ap);
}

/**
 * lapiz_message_get_valist:
 * @message: the #LapizMessage
 * @var_args: a %NULL variable argument list of key/value container pairs
 *
 * Get values of message arguments. The supplied @var_args should contain
 * pairs of keys and pointers to variables which are set to the argument
 * value for the specified key.
 *
 */
void
lapiz_message_get_valist (LapizMessage *message,
			  va_list 	var_args)
{
	const gchar *key;

	g_return_if_fail (LAPIZ_IS_MESSAGE (message));

	while ((key = va_arg (var_args, const gchar *)) != NULL)
	{
		GValue *container;
		GValue copy = {0,};
		gchar *error = NULL;

		container = value_lookup (message, key, FALSE);

		if (!container)
		{
			/* skip value */
			va_arg (var_args, gpointer);
			continue;
		}

		/* copy the value here, to be sure it isn't tainted */
		g_value_init (&copy, G_VALUE_TYPE (container));
		g_value_copy (container, &copy);

		G_VALUE_LCOPY (&copy, var_args, 0, &error);

		if (error)
		{
			g_warning ("%s: %s", G_STRLOC, error);
			g_free (error);

			/* purposely leak the value here, because it might
			   be in a bad state */
			continue;
		}

		g_value_unset (&copy);
	}
}

/**
 * lapiz_message_get_value:
 * @message: the #LapizMessage
 * @key: the argument key
 * @value: (out): value return container
 *
 * Get the value of a specific message argument. @value will be initialized
 * with the correct type.
 *
 */
void
lapiz_message_get_value (LapizMessage *message,
			 const gchar  *key,
			 GValue	      *value)
{
	GValue *container;

	g_return_if_fail (LAPIZ_IS_MESSAGE (message));

	container = value_lookup (message, key, FALSE);

	if (!container)
	{
		g_warning ("%s: Invalid key `%s'",
			   G_STRLOC,
			   key);
		return;
	}

	g_value_init (value, G_VALUE_TYPE (container));
	set_value_real (value, container);
}

/**
 * lapiz_message_get_key_type:
 * @message: the #LapizMessage
 * @key: the argument key
 *
 * Get the type of a message argument.
 *
 * Return value: the type of @key
 *
 */
GType
lapiz_message_get_key_type (LapizMessage    *message,
			    const gchar	    *key)
{
	g_return_val_if_fail (LAPIZ_IS_MESSAGE (message), G_TYPE_INVALID);
	g_return_val_if_fail (message->priv->type != NULL, G_TYPE_INVALID);

	return lapiz_message_type_lookup (message->priv->type, key);
}

/**
 * lapiz_message_has_key:
 * @message: the #LapizMessage
 * @key: the argument key
 *
 * Check whether the message has a specific key.
 *
 * Return value: %TRUE if @message has argument @key
 *
 */
gboolean
lapiz_message_has_key (LapizMessage *message,
		       const gchar  *key)
{
	g_return_val_if_fail (LAPIZ_IS_MESSAGE (message), FALSE);

	return value_lookup (message, key, FALSE) != NULL;
}

typedef struct
{
	LapizMessage *message;
	gboolean valid;
} ValidateInfo;

static void
validate_key (const gchar  *key,
	      GType         type G_GNUC_UNUSED,
	      gboolean	    required,
	      ValidateInfo *info)
{
	GValue *value;

	if (!info->valid || !required)
		return;

	value = value_lookup (info->message, key, FALSE);

	if (!value)
		info->valid = FALSE;
}

/**
 * lapiz_message_validate:
 * @message: the #LapizMessage
 *
 * Validates the message arguments according to the message type.
 *
 * Return value: %TRUE if the message is valid
 *
 */
gboolean
lapiz_message_validate (LapizMessage *message)
{
	ValidateInfo info = {message, TRUE};

	g_return_val_if_fail (LAPIZ_IS_MESSAGE (message), FALSE);
	g_return_val_if_fail (message->priv->type != NULL, FALSE);

	if (!message->priv->valid)
	{
		lapiz_message_type_foreach (message->priv->type,
					    (LapizMessageTypeForeach)validate_key,
					    &info);

		message->priv->valid = info.valid;
	}

	return message->priv->valid;
}

// ex:ts=8:noet: