Cppcheck report - libbean (cppcheck 2.17.1-2): tests/libbean-ctk/plugin-manager-view.c

/*
 * plugin-manager-view.c
 * This file is part of libbean
 *
 * Copyright (C) 2010 - Garrett Regier
 *
 * libbean is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * libbean is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA.
 */

#ifdef HAVE_CONFIG_H
#include <config.h>
#endif

#include <glib.h>
#include <ctk/ctk.h>
#include <libbean/bean.h>
#include <libbean-ctk/bean-ctk.h>

#include "testing/testing.h"

typedef struct _TestFixture TestFixture;

struct _TestFixture {
  BeanEngine *engine;
  CtkTreeView *tree_view;
  BeanCtkPluginManagerView *view;
  CtkTreeSelection *selection;
  CtkTreeModel *model;
  CtkListStore *store;
};

static void
notify_model_cb (CtkTreeView *view G_GNUC_UNUSED,
		 GParamSpec  *pspec G_GNUC_UNUSED,
		 TestFixture *fixture)
{
  fixture->model = ctk_tree_view_get_model (fixture->tree_view);

  if (CTK_IS_TREE_MODEL_FILTER (fixture->model))
    {
      CtkTreeModelFilter *filter = CTK_TREE_MODEL_FILTER (fixture->model);
      fixture->store = CTK_LIST_STORE (ctk_tree_model_filter_get_model (filter));
    }
  else
    {
      fixture->store = CTK_LIST_STORE (fixture->model);
    }
}

static void
test_setup (TestFixture   *fixture,
	    gconstpointer  data G_GNUC_UNUSED)
{
  fixture->engine = testing_engine_new ();
  fixture->tree_view = CTK_TREE_VIEW (bean_ctk_plugin_manager_view_new (NULL));
  fixture->view = BEAN_CTK_PLUGIN_MANAGER_VIEW (fixture->tree_view);
  fixture->selection = ctk_tree_view_get_selection (fixture->tree_view);

  g_signal_connect (fixture->view,
                    "notify::model",
                    G_CALLBACK (notify_model_cb),
                    fixture);

  /* Set the model and store */
  g_object_notify (G_OBJECT (fixture->tree_view), "model");

  g_object_ref_sink (fixture->tree_view);
}

static void
test_teardown (TestFixture   *fixture,
	       gconstpointer  data G_GNUC_UNUSED)
{
  ctk_widget_destroy (CTK_WIDGET (fixture->tree_view));
  g_object_unref (fixture->tree_view);

  testing_engine_free (fixture->engine);
}

static void
test_runner (TestFixture   *fixture,
             gconstpointer  data)
{
  ((void (*) (TestFixture *)) data) (fixture);
}

/* Based on code from bean-ctk-manager-view.h */
static void
convert_iter_to_child_iter (BeanCtkPluginManagerView *view,
                            CtkTreeIter              *iter)
{
  CtkTreeModel *model;
  CtkTreeIter child_iter;

  if (bean_ctk_plugin_manager_view_get_show_builtin (view))
    return;

  model = ctk_tree_view_get_model (CTK_TREE_VIEW (view));

  ctk_tree_model_filter_convert_iter_to_child_iter (CTK_TREE_MODEL_FILTER (model),
                                                    &child_iter, iter);

  *iter = child_iter;
}

static gboolean
model_has_builtin (TestFixture *fixture)
{
  CtkTreeIter iter;
  gboolean found = FALSE;

  if (ctk_tree_model_get_iter_first (fixture->model, &iter))
    {
      do
        {
          if (bean_plugin_info_is_builtin (testing_get_plugin_info_for_iter (fixture->view, &iter)))
            found = TRUE;
        }
      while (!found && ctk_tree_model_iter_next (fixture->model, &iter));
    }

  return found;
}

static void
test_ctk_plugin_manager_view_selection (TestFixture *fixture)
{
  CtkTreeIter iter;
  BeanPluginInfo *info;<--- Variable 'info' can be declared as pointer to const

  info = bean_ctk_plugin_manager_view_get_selected_plugin (fixture->view);
  g_assert (info == NULL);

  g_assert (ctk_tree_model_get_iter_first (fixture->model, &iter));
  ctk_tree_selection_select_iter (fixture->selection, &iter);

  info = bean_ctk_plugin_manager_view_get_selected_plugin (fixture->view);
  g_assert (info != NULL);
}

static void
test_ctk_plugin_manager_view_show_builtin (TestFixture *fixture)
{
  bean_ctk_plugin_manager_view_set_show_builtin (fixture->view, TRUE);

  g_assert (model_has_builtin (fixture));
}

static void
test_ctk_plugin_manager_view_hide_builtin (TestFixture *fixture)
{
  /* Should this be here given its already the default? */
  bean_ctk_plugin_manager_view_set_show_builtin (fixture->view, FALSE);

  g_assert (!model_has_builtin (fixture));
}

static void
test_ctk_plugin_manager_view_reload (TestFixture *fixture)
{
  CtkTreeIter iter;
  BeanPluginInfo *removed_info, *selected_info;<--- Variable 'removed_info' can be declared as pointer to const<--- Variable 'selected_info' can be declared as pointer to const

  g_assert (ctk_tree_model_get_iter_first (fixture->model, &iter));
  ctk_tree_selection_select_iter (fixture->selection, &iter);
  removed_info = testing_get_plugin_info_for_iter (fixture->view, &iter);

  convert_iter_to_child_iter (fixture->view, &iter);
  ctk_list_store_remove (fixture->store, &iter);

  g_assert (ctk_tree_model_get_iter_first (fixture->model, &iter));
  ctk_tree_selection_select_iter (fixture->selection, &iter);
  selected_info = testing_get_plugin_info_for_iter (fixture->view, &iter);

  g_object_notify (G_OBJECT (fixture->engine), "plugin-list");

  g_assert (ctk_tree_selection_get_selected (fixture->selection, NULL, &iter));
  g_assert (testing_get_plugin_info_for_iter (fixture->view, &iter) == selected_info);

  g_assert (ctk_tree_model_get_iter_first (fixture->model, &iter));
  g_assert (testing_get_plugin_info_for_iter (fixture->view, &iter) == removed_info);
}

static void
test_ctk_plugin_manager_view_enable_plugin (TestFixture *fixture)
{
  CtkTreeIter iter;
  CtkTreePath *path;
  CtkTreeViewColumn *column;
  BeanPluginInfo *info;

  g_assert (ctk_tree_model_get_iter_first (fixture->model, &iter));
  info = testing_get_plugin_info_for_iter (fixture->view, &iter);
  path = ctk_tree_model_get_path (fixture->model, &iter);
  column = ctk_tree_view_get_column (fixture->tree_view, 0);

  g_assert (!bean_plugin_info_is_loaded (info));
  ctk_tree_view_row_activated (fixture->tree_view, path, column);
  g_assert (bean_plugin_info_is_loaded (info));

  ctk_tree_path_free (path);
}

static void
test_ctk_plugin_manager_view_enable_builtin_plugin (TestFixture *fixture)
{
  CtkTreeIter iter;
  CtkTreePath *path;
  CtkTreeViewColumn *column;
  BeanPluginInfo *info;

  bean_ctk_plugin_manager_view_set_show_builtin (fixture->view, TRUE);

  info = bean_engine_get_plugin_info (fixture->engine, "builtin");

  testing_get_iter_for_plugin_info (fixture->view, info, &iter);

  path = ctk_tree_model_get_path (fixture->model, &iter);
  column = ctk_tree_view_get_column (fixture->tree_view, 0);

  g_assert (!bean_plugin_info_is_loaded (info));
  ctk_tree_view_row_activated (fixture->tree_view, path, column);
  g_assert (!bean_plugin_info_is_loaded (info));

  ctk_tree_path_free (path);
}

int
main (int    argc,
      char **argv)
{
  testing_init (&argc, &argv);

#define TEST(path, ftest) \
  g_test_add ("/ctk/plugin-manager-view/" path, TestFixture, \
              (gpointer) test_ctk_plugin_manager_view_##ftest, \
              test_setup, test_runner, test_teardown)

  TEST ("selection", selection);

  TEST ("show-builtin", show_builtin);
  TEST ("hide-builtin", hide_builtin);

  TEST ("reload", reload);

  TEST ("enable-plugin", enable_plugin);
  TEST ("enable-builtin-plugin", enable_builtin_plugin);

#undef TEST

  return testing_run_tests ();
}